add gnmirpc to oc paths #3463
Merged
add gnmirpc to oc paths #3463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11133359002Details
💛 - Coveralls |
Change names of the enums to be a bit clearer and change default value to hold no information.
dplore
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent is to be able to allow both requirements to be made clearer by attaching the required RPC level of support (get, set, subscribe), as well as more detailed information about the current level of support.
Just because a path is supported under
gnmi.Getdoesn't mean it's supportedON_CHANGEin agnmi.Subscribe!The messages can be used to either list requirements or, if describing a particular target, it can be used to describe the level of support a target provides.
For read paths, we allow specification of desired (or implemented) support level: streaming, subscribe once, or polling.
Additionally, for paths requiring streaming support, we add specifications for the subscription type: target defined, on change, or sampled.
Finally, we add a
sample_interval_nanoseconds, which can be used as a 'maximum desired cadence', if specified as a requirement or the 'minimum recommended cadence' if describing a target's capabilities.For a target, a cadence of
0(when theSubscriptionModeincludesON_CHANGEas supported) describesON_CHANGEas the recommended frequency of subscription.